Add visionOS and tvOS triplets to Ferric #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
Ferric 🦀
Apple 🍎
…" and add ":apple" and ":android" scripts
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for visionOS and tvOS target triplets to the Ferric Rust build tooling and implements a CI workflow to test these platforms using the nightly Rust compiler.
Key changes:
- Introduces third-tier target support requiring nightly Rust toolchain with
build-std - Refactors build scripts to use composable
node --runcommands - Adds comprehensive CI testing for Apple platform triplets
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/host/package.json | Refactored build scripts to use composable commands and renamed all-triplets to all |
| packages/ferric/src/targets.ts | Added visionOS/tvOS targets, implemented nightly toolchain detection, and renamed ensureInstalledTargets to ensureAvailableTargets |
| packages/ferric/src/cargo.ts | Added XCFramework mappings for visionOS/tvOS and conditional nightly toolchain usage with build-std flag |
| packages/ferric/src/build.ts | Added tvOS simulator library combining logic to match existing iOS simulator handling |
| .github/workflows/check.yml | Added new CI job to test ferric Apple triplets with nightly Rust compiler |
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: lts/jod |
There was a problem hiding this comment.
Corrected spelling of 'jod' to 'jod'. This should be 'lts/iron' or another valid LTS codename.
Suggested change
| node-version: lts/jod | |
| node-version: lts/iron |
Copilot AI
added a commit
that referenced
this pull request
Oct 27, 2025
Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR will: